Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Restore jump nav and content width #994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lunyachek
Copy link
Contributor

@Lunyachek Lunyachek commented Feb 8, 2024

Our proposal is to modify the width values of jump-nav and content to their state prior to this pull request - #784. In this pull request, the width of the jump nav was reduced, and the width of the content was increased. This results in the jump nav appearing very narrow on themes with a maximum container width. Even the phrase "Account Information" does not fit into a single line
Снимок экрана 2024-02-08 в 14 04 57

After this small fix we'll restore previous state of the columns width, like in Palm
Снимок экрана 2024-02-08 в 14 17 59

@openedx-webhooks
Copy link

openedx-webhooks commented Feb 8, 2024

Thanks for the pull request, @Lunyachek!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/edx-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.53%. Comparing base (3467534) to head (a0f182f).
Report is 101 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #994   +/-   ##
=======================================
  Coverage   56.53%   56.53%           
=======================================
  Files         118      118           
  Lines        2457     2457           
  Branches      654      654           
=======================================
  Hits         1389     1389           
  Misses        997      997           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

Hi @openedx/fed-bom! Are you still reviewing / merging OSPRs? If so this one is ready. If not, please let me know.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
@mphilbrick211
Copy link

Hi @openedx/2u-aperture! Would someone be able to review this for us? Along with the backport?

@justinhynes
Copy link
Contributor

Hi @mphilbrick211,

Apologies in advance, Aperture are not maintainers for this MFE, so I'm not sure if we have the time and expertise to help here.

@mphilbrick211
Copy link

Hi @mphilbrick211,

Apologies in advance, Aperture are not maintainers for this MFE, so I'm not sure if we have the time and expertise to help here.

Hi @justinhynes - it looks like Aperture is going to take it over?

@justinhynes
Copy link
Contributor

@mphilbrick211 News to me! I'll double check. 😅

@justinhynes
Copy link
Contributor

@mphilbrick211 Apologies for the delay. I did check internally, and I was under the impression that the @openedx/2u-vanguards will be the maintainers of the Account MFE.

@mphilbrick211
Copy link

Hi @openedx/2u-vanguards! Are you able to take a look at this for us? Thanks!

@mphilbrick211 mphilbrick211 added needs reviewer assigned PR needs to be (re-)assigned a new reviewer and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants